Custom Query (1828 matches)


Show under each result:

Results (46 - 48 of 1828)

Ticket Resolution Summary Owner Reporter
#547 fixed (in master) Trap detection should detect traps on chests. artes Big Al <Big Al>

Trap detection spell should detect traps on chests (only if in LOS of the chest?).

#157 fixed (in master) Comment cleanups CJNyfalt

The following comments are either wrong or need cleanups:

  • z-file.c: fd_lock: G_SETLK in comment should be F_SETLK.
  • h-basic.h: The comment about types should read "We should really be able to use the C99 types ...", not C89.
  • h-basic.h: The L64 comment should be removed from the #endif about s32b/u32b types. L64 define doesn't exist anymore.
  • h-basic.h: The last #endif in the file should have an /* INCLUDED_H_BASIC_H */ comment.

BTW, renaming the SET_UID define to UNIX would be more descriptive.

#159 fixed (in master) Trimming down the number of compile-time options CJNyfalt

Compile-time options (defines) are more annoying than in-game options because they are hard to debug, and should be kept to a minimum.

I suggest removal of the following (from config.h and other files):

  • SAFE_SETUID & SAFE_SETUID_POSIX (on): See my post on the forum some days ago.
  • ALLOW_AUTOROLLER (on): There are variants where the game won't even compile if this one is turned off.
  • ALLOW_REPEAT (on): This is an important part of the UI, and there should be no reason to turn it off.
  • CAPITALIZE_USER_NAME (on): No reason at all to have this as an option.

Other issues in config.h:

  • GJW_RANDART is still present in the ANGBAND_LITE block even if it has been removed.
  • MONSTER_FLOW_DEPTH doesn't belong in this file.
  • A comment on why Macs and Windows machines doesn't handle signals would also be welcome.
Note: See TracQuery for help on using queries.