Opened 11 years ago

Closed 11 years ago

#1013 closed bug (fixed (in master))

Multiple brands/slays should print only one message

Reported by: magnate Owned by: magnate
Milestone: 3.1.2 beta Keywords: items


Logically, if we use only the highest multiplier, we should print only the corresponding message. Although printing the messages for all applicable brands/slays adds flavour, it quickly becomes tedious - as I found out with a triple-branded randart.

Change History (2)

comment:1 Changed 11 years ago by magnate

  • Status changed from new to assigned

Just to clarify: you only get one message from the weapon, regardless of how many brands it has. But at the moment you also get a message from every off-weapon brand. IMO you should get only the message for the brand that's actually being used to calculate the damage. If you have two identical off-weapon brands (e.g. Paurnimmen and a Ring of Ice) you should still get only one message if they're both IDd (I think an exception can be made for ID-by-use learning messages, as you only need those once).

comment:2 Changed 11 years ago by magnate

  • Resolution set to fixed
  • Status changed from assigned to closed

[87e98c4] (SVN r1798). Messages are only printed the first time the flag is noticed. Until brands are removed from TR0_OBVIOUS_MASK, only slays will generate messages.

Note: See TracTickets for help on using tickets.