Opened 7 years ago

Last modified 4 years ago

#1030 confirmed change

Better save location and output for char dump

Reported by: d_m Owned by:
Milestone: Future Keywords: dump ui
Cc:

Description (last modified by takkaria)

At least on Linux, my dumps get saved into $HOME/.angband/Angband/Aragorn.txt

The message that prints says something like: dump saved in "Aragorn.txt"

I think it would be better to give the full (relative or absolute) path to the file that was saved. At least on Linux, I also think the dump should be saved to the current directory, rather than in ~/.angband.

Thoughts?

Change History (8)

comment:1 Changed 7 years ago by magnate

Agreed about the "saved in path/to/filename" output on the screen, but definitely not that dumps should be saved in the pwd. The whole point of ANGBAND_DIR_USER is that that's where chardumps are saved (and user prefs etc.). Anyone can configure the USER dir to be wherever they want at build/install time, so why would we ignore this?

comment:2 follow-up: Changed 7 years ago by takkaria

For GUI ports, really we want to allow people to hook in some native UI for choosing save location.

comment:3 Changed 7 years ago by magnate

  • Keywords recall ui added
  • Milestone changed from Triage to 3.1.2 beta
  • Status changed from new to confirmed

comment:4 in reply to: ↑ 2 Changed 7 years ago by magnate

  • Milestone changed from 3.1.2 beta to 3.1.3

Replying to takkaria:

For GUI ports, really we want to allow people to hook in some native UI for choosing save location.

Apparently the way was prepared in #513 ([c18feef] (SVN r1066))

comment:5 Changed 7 years ago by magnate

  • Keywords dump added; recall removed

comment:6 Changed 6 years ago by magnate

  • Milestone changed from 3.2.0 to 3.3.0

Punting to 3.3: non-urgent bug or change.

comment:7 Changed 6 years ago by magnate

  • Milestone changed from 3.3.0 to Future

Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).

comment:8 Changed 4 years ago by takkaria

  • Description modified (diff)

I've added a line giving the full path for where the file gets saved to.

I guess I'm split. On systems where you can use a graphical file selector, I think this is easy to fix. But for curses/X11 it seems a lot harder. I think it's unintuitive to save the character dump to a file in a hidden directory, definitely. Maybe for curses a better default is the current working directory?

Note: See TracTickets for help on using tickets.