Opened 10 years ago

Closed 9 years ago

#1132 closed bug (fixed (in master))

Refueling a normal torch with a torch of Brightness

Reported by: anonymous Owned by:
Milestone: 3.2.0 Keywords: items
Cc:

Description

Correct me if I'm wrong, but this combines the two torches... eating the "Brightness" property in the process. No problem with lanterns as they never combine (so you keep your empty lantern of Brightness in inventory), but something should prevent "combining" a torch with an ego torch no? After all, they are not "similar"...

Change History (3)

comment:1 Changed 10 years ago by magnate

To me this looks like WAD, and the obvious solution would be to prompt before using an ego torch as a refuel source. But I know takkaria doesn't like extra prompts, so ....

comment:2 Changed 10 years ago by magnate

  • Keywords items added

comment:3 Changed 9 years ago by magnate

  • Milestone changed from Triage to 3.1.3
  • Resolution set to fixed
  • Status changed from new to closed

[bcb512d] (SVN r2007). The OF_LIGHT flag is transferred if the wielded torch doesn't have it, and the ego type is set to Of Brightness if the wielded torch is not an ego item. This allows for any future ego torches without OF_LIGHT to have OF_LIGHT added by refueling from a Torch of Brightness. In the meantime, people accidentally using a torch of Brightness to refuel a normal torch will not lose out.

Note: See TracTickets for help on using tickets.