Opened 9 years ago

Closed 9 years ago

#1167 closed bug (fixed (in master))

Fix preserve off mode

Reported by: magnate Owned by: magnate
Milestone: 3.2.0 Keywords: items
Cc:

Description

At the moment it only shows identified-then-lost artifacts. With preserve on, this is all of them, but with preserve off we need to include generated-but-never-IDd artifacts.

Surfaced by comp 89/90.

Change History (5)

comment:1 Changed 9 years ago by magnate

  • Keywords recall added; knowledge removed
  • Owner set to magnate
  • Status changed from new to assigned

comment:2 Changed 9 years ago by magnate

Noz points out that history_lose_artifact comes into play here: this same group of generated-but-not-IDd artifacts never shows up on the history either.

comment:3 Changed 9 years ago by magnate

  • Keywords items added; recall removed
  • Status changed from assigned to confirmed
  • Summary changed from Knowledge menu should show all lost artifacts to Fix preserve off mode
Oooh. I just confirmed that preserve off doesn't work at all! The code in wipe_o_list() (in obj-util.c) which preserves artifacts if (!character_dungeon
!OPT(adult_no_preserve)) is preserving them in every case, even if preserve is off. Tested by using cheat_peek.

comment:4 Changed 9 years ago by magnate

Ok, found the bug. Now just need to know whether unIDd lost artifacts should show up in the knowledge menu and/or the player history: see http://angband.oook.cz/forum/showthread.php?t=3413 for the poll.

comment:5 Changed 9 years ago by magnate

  • Resolution set to fixed
  • Status changed from confirmed to closed

[f02f849] (SVN r1987). Artifacts are now properly lost when playing with no_preserve, and they show up in the knowledge menu (albeit without any details) and in the character history (but only on death).

Note: See TracTickets for help on using tickets.