Opened 7 years ago

Last modified 5 years ago

#1173 confirmed bug

Multiple Allocation lines broken

Reported by: magnate Owned by: magnate
Milestone: v4 Keywords: items,affixes
Cc:

Description

Not confirmed yet, but see this thread:

http://angband.oook.cz/forum/showthread.php?t=3461

Change History (5)

comment:1 Changed 7 years ago by magnate

  • Milestone changed from Triage to Future
  • Status changed from new to confirmed

Confirmed that only the last A: line is actually saved in the k_info[] structure. Enabling multiple A: lines will mean changes to parse_k_info() in init1.c, and to init_obj_alloc() in object/obj-make.c - but should work with just those two changes, as init_obj_alloc() creates a rarity table covering every object on every dungeon level. Such a function does not (yet) exist for artifacts, so enabling multiple A: lines for artifacts will mean changes to parse_a_info() in init1.c and either (i) creating an init_artifact_alloc() function, or (ii) adding multiple min/max/alloc_prob elements to the a_ptr structure. The former solution is vastly more elegant.

Ego types still use the old "rarity" instead of alloc_prob, so we probably need a separate ticket for that.

comment:2 Changed 5 years ago by magnate

  • Milestone changed from Future to 3.4.0
  • Owner set to magnate
  • Status changed from confirmed to pending

These are all done (or at least underway) in http://github.com/magnate/angband/tree/affixes.

comment:3 Changed 5 years ago by magnate

  • Keywords items,affixes added; items removed

This ticket is addressed in (or enabled by) https://github.com/angband/angband/pull/94

comment:4 Changed 5 years ago by magnate

  • Milestone changed from 3.4.0 to Future
  • Status changed from pending to confirmed

Actually this is only done for affixes (e_info) and artifacts (a_info). It still needs doing for k_info.

comment:5 Changed 5 years ago by magnate

  • Milestone changed from Future to 4.0

Initial assignment to v4 per http://trac.rephial.org/roadmap

Note: See TracTickets for help on using tickets.