#1228 closed bug (fixed (in master))
Code cleanup: o_ptr->pval still used for rods in some places
Reported by: | Zaxx | Owned by: | magnate |
---|---|---|---|
Milestone: | 3.2.0 | Keywords: | cleanup |
Cc: |
Description
Since now rods use o_ptr->timeout and k_ptr->time to handle activation, the occurences of o_ptr->pval should be removed/replaced.
In object_absorb():
o_ptr->pval = total * j_ptr->pval; (remove)
In inven_damage():
o_ptr->pval -= o_ptr->pval * amt / o_ptr->number; (bug: need to use reduce_charges instead)
In wiz_quantity_item():
o_ptr->pval = (o_ptr->pval / o_ptr->number) * tmp_int; (same problem)
In store_object_similar():
check (o_ptr->tval != TV_ROD) on pval (remove)
Change History (4)
comment:1 Changed 8 years ago by Zaxx
comment:2 Changed 8 years ago by magnate
- Keywords cleanup added
- Milestone changed from Triage to 3.2.0
- Owner set to magnate
- Status changed from new to assigned
I'll take this - thanks for the analysis.
comment:3 Changed 8 years ago by magnate
- Status changed from assigned to pending
http://bit.ly/eIkKcc - thanks for pointing these out.
comment:4 Changed 8 years ago by magnate
- Resolution set to fixed
- Status changed from pending to closed
Note: See
TracTickets for help on using
tickets.
In store_object_absorb(): no need to add the timeouts for rods since they are automatically recharged (see store_carry).