Opened 9 years ago

Closed 5 years ago

#1237 closed task (fixed (in master))

Remove hard-coded limits

Reported by: apwhite Owned by: elly
Milestone: Future Keywords: cleanup
Cc:

Description (last modified by nckmccnnll)

The z_info->k_max counts the number of kinds of items. It is listed as:

# Maximum number of object kinds
M:K:570

in limits.txt. Based on the current objects.txt, it should be

M:K:565

z_info->k_max overruns can cause some problems with object descriptions and kind index values.

And, less importantly, it freaks the borg out and forces him to cheat.


Hmmm. This is actually an ideal target for the next time elly says "what should I nuke next?". We really should get rid of limits.txt altogether, and set the foo_info->bar_max variables at the end of each parser. If not removing those globals altogether.

Change History (5)

comment:1 Changed 9 years ago by noz

I think we should fix the problems, rather than relying on the two values being kept in step. Of course, ideally, we'd get rid of hard-coded limits like that, but that's a little way away.

Could you describe the problems?

comment:2 Changed 9 years ago by magnate

  • Description modified (diff)
  • Keywords cleanup added
  • Milestone changed from Triage to 3.3.0
  • Owner set to elly
  • Status changed from new to assigned
  • Summary changed from z_info->k_max is too high in limits.txt to Remove hard-coded limits

comment:3 Changed 9 years ago by magnate

  • Type changed from bug to task

comment:4 Changed 8 years ago by magnate

  • Milestone changed from 3.3.0 to Future
  • Status changed from assigned to confirmed

Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).

comment:5 Changed 5 years ago by nckmccnnll

  • Description modified (diff)
  • Resolution set to fixed (in master)
  • Status changed from confirmed to closed

Done - all limits relating to edit files are now set as a consequence of reading the edit files

Note: See TracTickets for help on using tickets.