Opened 8 years ago

Closed 8 years ago

#1269 closed bug (fixed (in master))

Object origin text does not render xchars properly in non-Latin charsets

Reported by: d_m Owned by:
Milestone: 3.4.0 Keywords: recall xchars
Cc:

Description

If you play with Latin-1 (x-char) support then logs get written with Latin-1 characters. If you then play in a port without Latin-1 support, things break.

As an example, if Ugluk drops an item while playing with SDL (which supports Latin-1) and then you (I)nspect the item under GCU, there is a problem (although if you do (r)ecall and look up Ugluk, his name displays correctly).

This ticket just helps document the character encoding mess we've gotten ourselves into.

Change History (5)

comment:1 Changed 8 years ago by magnate

  • Keywords recall xchars added; latin-1 utf-8 removed
  • Milestone changed from Triage to 3.3.0
  • Status changed from new to confirmed

To be clear, we are talking about the display of object origin when "I"nspecting the object. The suggestion is that while normal display of monster names handles xchars (or their absence) properly, the object inspection code doesn't.

Confirmed: I kill Grishnakh in SDL and picked up his drop, then quit. When I loaded up in GCU, the origin text is displayed wrongly, despite Grishnakh being displayed properly in monster recall.

comment:2 Changed 8 years ago by magnate

  • Summary changed from Logs saved in Latin-1 fail to Object origin text does not render xchars properly in non-Latin charsets

comment:3 Changed 8 years ago by magnate

takkaria confirms that this needs xchar handling added to textblock_append()

comment:4 Changed 8 years ago by magnate

  • Milestone changed from 3.3.0 to Future

Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).

comment:5 Changed 8 years ago by magnate

  • Milestone changed from Future to 3.4.0
  • Resolution set to fixed
  • Status changed from confirmed to closed

Fixed by the UTF8 change (see #1221).

Note: See TracTickets for help on using tickets.