Opened 6 years ago

Last modified 2 years ago

#1377 confirmed task

Copyright notices are inconsistent.

Reported by: myshkin Owned by:
Milestone: Future Keywords: cleanup gpl
Cc:

Description

The copyright notice embedded in the executable (see variable.c) is out of date. In addition, the copyright notices on individual source files are inconsistent, and some are missing.

Change History (9)

comment:1 Changed 6 years ago by takkaria

So I don't think header files should have copyright notices, but all .c files should have them. If you make a substantial edit to a file, you should add another (c) YYYY Name line to the top. What do you mean by inconsistent copyright notices? They should all be the same as the text in HEADER apart from the MIT-licensed files...

comment:2 Changed 6 years ago by myshkin

Some inconsistencies:

  • Not all C files have a full header, e.g. player/util.c has nothing, and player/player.c just has
    /* player/player.c - player implementation */
    
  • The File: field sometimes includes the patch relative to top of tree or relative to src/, and sometimes just has the filename.
  • The copyright notice sometimes includes e-mail addresses, but not always. It is not clear to me whether the years are correct in all cases.

I can try to go through the git logs to fill these in, or chase down contributors.

comment:3 Changed 6 years ago by myshkin

  • Summary changed from Copyright notices are out of date. to Copyright notices are inconsistent.

comment:4 Changed 6 years ago by takkaria

The years should generally be roughly correct. It would be good for emails to be included where possible, too.

comment:5 Changed 6 years ago by magnate

  • Keywords gpl added
  • Status changed from new to confirmed
  • Type changed from bug to task

comment:6 follow-up: Changed 6 years ago by d_m

I have not been adding my name or year to most files I work with. Should I go back and do this?

comment:7 in reply to: ↑ 6 Changed 6 years ago by magnate

Replying to d_m:

I have not been adding my name or year to most files I work with. Should I go back and do this?

I think proportionately, yes. You should definitely do so for generate.c, for example. But if you've only touched a half-dozen lines fixing a bug, probably not.

comment:8 Changed 6 years ago by magnate

  • Milestone changed from 3.3.0 to Future

Not addressed in 3.3.0 - re-setting to Future as unowned

comment:9 Changed 2 years ago by nckmccnnll

I've carefully added copyright to most header files. Was that wrong?

Note: See TracTickets for help on using tickets.