Opened 9 years ago

Closed 8 years ago

#1399 closed task (fixed (in master))

Additional ORIGIN_ values

Reported by: magnate Owned by: magnate
Milestone: 3.3.0 Keywords: items
Cc:

Description

It's become clear during discussions on stats collection that ORIGIN_FLOOR and ORIGIN_DROP need to split into three:

ORIGIN_FLOOR, ORIGIN_PIT and ORIGIN_VAULT for floor items

ORIGIN_DROP, ORIGIN_DROP_PIT and ORIGIN_DROP_VAULT for monster items

We don't need a separate origin for unique drops, because we already record the ID of the monster who dropped the item. But we don't currently record any distinction between pits, vaults and other monsters.

If we wanted to, we could add ORIGIN_DROP_SUMMON as well, to track loot obtained from summons.

None of this needs to have a visible impact on gameplay - we can stick with the current text used for ORIGIN_FLOOR and ORIGIN_DROP.

Change History (5)

comment:1 Changed 9 years ago by magnate

  • Summary changed from Addition ORIGIN_ values to Additional ORIGIN_ values

comment:2 Changed 8 years ago by magnate

  • Status changed from new to confirmed

I think this will be a lot easier to implement if we create all drops at monster creation time. At that point, we know whether we are creating a monster in a pit or vault; by the time it is killed, there is no record of whether it originated in a pit or vault. I have created #1419 for this.

comment:3 Changed 8 years ago by magnate

  • Keywords items added; stats removed
  • Owner set to magnate
  • Status changed from confirmed to assigned

The new drop origins are implemented in [r3231ed6]. Just the floor origins to do.

comment:4 Changed 8 years ago by magnate

  • Status changed from assigned to pending

Finished in [refe7475].

comment:5 Changed 8 years ago by myshkin

  • Resolution set to fixed
  • Status changed from pending to closed

Fixed in master [712c297].

Note: See TracTickets for help on using tickets.