Opened 3 years ago

Last modified 6 months ago

#1424 confirmed change

Various issues with plural handling

Reported by: myshkin Owned by: myshkin
Milestone: Future Keywords: cleanup
Cc:

Description (last modified by myshkin)

Objects and monsters should have the same plural handling code. Monster pluralization should move to the edit file. While we're at it, fix Mumak/Mumakil and Craban/Crebain plurals.

Change History (9)

comment:1 Changed 3 years ago by myshkin

  • Description modified (diff)

comment:2 Changed 3 years ago by magnate

  • Milestone changed from 3.3.0 to Future
  • Status changed from new to confirmed

Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).

comment:3 Changed 3 years ago by magnate

There's also a pluraliser macro in monster1.c (and probably others - needs a grep for "plural").

comment:4 Changed 22 months ago by myshkin

Other plural issues:

  • h-basic.h defines PLURAL(n), while monster/mon-lore.c defines plural(c, s, p). I assume the latter is the macro to which magnate refers.
  • object/obj-util.c and wiz-stats.c call PLURAL(plural) to get an "s" or lack thereof for verb agreement. Here, plural is a bool. Since the PLURAL macro tests its argument against 1, that the macro works is quite difficult to see.
  • monster/mon-lore.c fails to do the same convoluted dance with the "who remain%s unavenged" string in describe_monster_kills(), and so our grammar is wrong. Spotted by Derakon on oook.
  • spells1.c:project_o() eschews these macros and rolls its own plural-handling code.
  • cmd-obj.c:activation_message() also has some verb agreement code.
  • The borg has some code for plurals as well.

comment:5 Changed 22 months ago by myshkin

  • Summary changed from Remove plural_aux() to Various issues with plural handling

comment:6 Changed 6 months ago by PowerWyrm

From D&D demon list:

  • Erinyes -> Erinyes
  • Hezrou -> Hezrous
  • Nalfeshnee -> Nalfeshnees

Also:

  • Cyclops -> Cyclopes

comment:7 Changed 6 months ago by takkaria

https://github.com/angband/angband/pull/274 has dealt with some (all?) of these issues.

comment:8 Changed 6 months ago by PowerWyrm

See my remarks above for other plural changes in monster.txt.

comment:9 Changed 6 months ago by takkaria

More fixes in 94549f4, pullreq https://github.com/angband/angband/pull/277

Note: See TracTickets for help on using tickets.