Opened 6 years ago

Last modified 6 years ago

#1449 confirmed change

Throwing should not ID-by-use for non-throwing items

Reported by: magnate Owned by:
Milestone: Future Keywords: id


Arguably certain things *should* be IDd by throwing (like brands, for example), but in general stuff like +hit and +dam and pvals should not be IDd except on throwing weapons.

This probably requires a more thoughtful overhaul of throwing first though: do we want specific throwing weapons, which could go in the quiver? Sangband has lots of good stuff here - throwing is actually a viable combat strategy there, which it isn't in V.

See also #1017 and #67.

Attachments (1)

reqpvals.txt (996 bytes) - added by eddiegrove 6 years ago.
Require visible pvals for id in check_for_ident

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by eddiegrove

There is no a bug here AFAICT. Everything is working properly. When you throw a dam+10 ring, it does 5 more damage than throwing a dam+5 ring, and you should learn that. If you want to change the definition of damage and hit bonus, separating into different melee, hit, and thrown values, do that first. The problem with selling prices is the premise that the shopkeeper knows what you know, another problem that is not the ID but something else.

comment:2 Changed 6 years ago by magnate

The shopkeeper/pricing issue is #1315. The different types of damage issue is #1436. I accept that doing that first would render this ticket invalid, and also that that would be the better order in which to do it. But since people find it odd that one can ID certain aspects of nonweapons by throwing them, we may wish to put in a quick fix for that before #1436 is done.

comment:3 Changed 6 years ago by eddiegrove

If it was broken, a quick fix might be in order. But since it is currently working correctly, you are talking about a quick breakage. Sorry to be curt and not discuss on oook, but am just very busy ATM.

comment:4 Changed 6 years ago by magnate

That's fine - your opinion that nothing is broken is very clearly recorded here for posterity. The opinion of Oook posters is that there is something wrong about objects which are not designed to inflict damage when thrown (like rings and amulets) being IDd by throwing. This ticket records that concern, in case anybody wants to fix it (by breaking what you consider is currently working properly). I hope that clears things up.

Changed 6 years ago by eddiegrove

Require visible pvals for id in check_for_ident

comment:5 Changed 6 years ago by eddiegrove

I managed to read the thread on oook, and there was a bug about pvals. My current work has changed things a bit, but I think I am attaching a proper fix for the current dev code.

comment:6 Changed 6 years ago by magnate

  • Status changed from new to confirmed
  • Type changed from bug to change

Ok, re-classifying as a change, which is essentially a subset of #1436.

Note: See TracTickets for help on using tickets.