Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1466 closed bug (fixed (in master))

Make sure carried artifacts don't give special feelings

Reported by: magnate Owned by: magnate
Milestone: 3.3.0 Keywords: items dungeon
Cc:

Description

The recent change to create monster drops at birth means that "special" level feelings are occurring every time a monster is generated carrying an artifact. They should only occur when an artifact is generated on the floor (since artifacts carried by monsters are not lost on leaving the level).

This is non-trivial, as c->good_item is set in obj-make, which doesn't know if we're generating a floor item or a carried item.

Change History (3)

comment:1 Changed 8 years ago by magnate

So, takkaria wants the code in obj-make not to mess with cave-> directly. This means that that adjustments to cave->feeling and cave->good_item need to be made after objects are created, back in the functions which call for their creation.

comment:2 Changed 8 years ago by magnate

  • Status changed from new to pending

[r40d63b8]

comment:3 Changed 8 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed

In master as of [ref5f4267]

Note: See TracTickets for help on using tickets.