Opened 3 years ago

Last modified 3 years ago

#1490 assigned bug

Stat coloring / message bugs

Reported by: GabeCunningham Owned by: myshkin
Milestone: Future Keywords: player ui
Cc:

Description

If a character has a stat with a baseline of 3, then stat reduction effects shouldn't give a message or recolor the stat. See http://angband.oook.cz/forum/showthread.php?p=56594.

Change History (6)

comment:1 Changed 3 years ago by artes

  • Owner set to artes
  • Status changed from new to assigned

I think I have found a solution to this.

comment:2 Changed 3 years ago by myshkin

artes reported experimenting with a HT warrior and a rot jelly. When I did so, I have stat_cur[5] == 8, stat_max[5] == 10, state.stat_use[5] == 3. In the main screen, charisma remains a green 3 until I force a redraw. In the character info screen (press 'C'), there is no indication that my charisma is affected.

My objection to artes's fix is that, if the effective charisma is 3, as in the case above, stat_cur won't get drained at all. If effective charisma is 3, should the base stat get drained? If so, should the player notice, even though the effective stat doesn't change? I'd argue yes and yes.

Adding PR_STATS to p->redraw in adjust_level() fixes the issue with leveling up. I've made some changes consistent with the above in 7b28736 on myshkin/staging.

comment:3 Changed 3 years ago by artes

  • Owner changed from artes to myshkin

Ok, I'll assign the ticket to you.

comment:4 Changed 3 years ago by myshkin

  • Keywords player ui added
  • Milestone changed from 3.3.0 to 3.4.0

Punting to 3.4. Relies on message sequencing, and may also need a gameplay decision about draining's operating on base stats versus observed stats.

comment:5 Changed 3 years ago by fizzix

  • Milestone changed from 3.4.0 to 3.5.0

comment:6 Changed 3 years ago by fizzix

changed to 3.5 per conversation in IRC

Note: See TracTickets for help on using tickets.