Opened 8 years ago

Closed 7 years ago

#1512 closed bug (fixed (in master))

use of S_IREAD and S_IWRITE in z-file.c

Reported by: david3x3x3 Owned by:
Milestone: 3.3.1 Keywords: compat
Cc:

Description

I don't think these macros are very portable. The code no longer compiles on Android because they aren't defined. Can we change these to S_IRUSR and S_IWUSR? This will fix Android, but I'm not sure if it will break other systems.

Change History (3)

comment:1 Changed 8 years ago by david3x3x3

I've sent a pull request to fix this on Github.

comment:2 Changed 7 years ago by magnate

  • Keywords compat added
  • Milestone changed from Triage to 3.3.1
  • Status changed from new to pending

This was merged in [rf41ebb07]. Pending backport to 3.3.1

comment:3 Changed 7 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed

Backported as [rf2213a0] (adjusted cherry-pick).

Note: See TracTickets for help on using tickets.