Opened 6 years ago

Last modified 19 months ago

#1530 confirmed task

Fix curly braces, space indenting, line endings, and trailing whitespace

Reported by: d_m Owned by:
Milestone: Future Keywords: cleanup
Cc:

Description (last modified by nckmccnnll)

After updating our coding standard many old files haven't been updated. I've been reluctant to do it in a way that would cause problems for people's personal trees, but maybe now is a good time.

Also, some files have other problems such as:

  1. DOS line-endings (\r\n)
  2. space indenting (e.g. mixing tabs and spaces for indenting)
  3. trailing whitespace

It might be good to fix this all in one go, as well as setting up some kind of lint script which we can use to find obvious style violations. It would be super extra good to make it an easy to use part of the build, so that contributors can easily see when they are going wrong. This might be too annoying though...

Change History (2)

comment:1 Changed 6 years ago by magnate

  • Keywords cleanup added; clenaup removed
  • Milestone changed from Triage to Future
  • Status changed from new to confirmed
  • Type changed from change to task

I wholly support the idea of a checking script which people can run before committing changes. I think this divides into two tasks then:

  1. A single-pass find-and-replace to sort out line endings, tabs and whitespace (presumably done with sed-fu?)
  1. A script to check the above three things and other things like opening braces, spaces before and after parens etc. (git diff | script)

comment:2 Changed 19 months ago by nckmccnnll

  • Description modified (diff)

A lot of this happened in the 3.5.1 -> 4.0.0 change, but not all

Note: See TracTickets for help on using tickets.