Opened 7 years ago

Closed 7 years ago

#1537 closed bug (fixed (in master))

Toggling birth_randarts is broken

Reported by: magnate Owned by: magnate
Milestone: 3.4.0 Keywords: items loadsave
Cc:

Description

  1. Create a character with randarts. Find or create an artifact - see that it's random, not one of the standard set. Suicide. Choose to "keep randarts". Exit and restart.
  1. At the quickstart screen, press N to go back to the beginning of the birth process. Press = to enter options, and toggle birth_randarts to No. Leave options and finish birth. Create an artifact ... it ought to be a standart, but it isn't, it's a randart.

This doesn't happen if keep_randarts is off. This bug is extant in 3.3.0!!

Change History (3)

comment:1 Changed 7 years ago by magnate

This is happening because randarts are loaded from the savefile if birth_keep_randarts is true, and there is as yet no call to re-set them to standarts if birth_randarts is turned off between loading them and starting the game. Not sure why I didn't spot this before, but it doesn't seem to have affected too many people.

comment:2 Changed 7 years ago by magnate

  • Keywords items loadsave added; blocker removed
  • Milestone changed from 3.3.1 to 3.4.0
  • Status changed from new to pending

Fixed in [r9a2a567c] which needs merging to master from http://github.com/magnate/angband/tree/randarts. Not suitable for porting back to 3.3.1 because it messes with savefile loading and saving - and nobody has reported the problem in 3.3.0 so it obviously isn't critical.

comment:3 Changed 7 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed

Finally fixed in [rb7731c694].

Note: See TracTickets for help on using tickets.