Opened 10 years ago

Closed 10 years ago

#159 closed task (fixed (in master))

Trimming down the number of compile-time options

Reported by: CJNyfalt Owned by:
Milestone: 3.0.8 Keywords: cleanup
Cc:

Description (last modified by takkaria)

Compile-time options (defines) are more annoying than in-game options because they are hard to debug, and should be kept to a minimum.

I suggest removal of the following (from config.h and other files):

  • SAFE_SETUID & SAFE_SETUID_POSIX (on): See my post on the forum some days ago.
  • ALLOW_AUTOROLLER (on): There are variants where the game won't even compile if this one is turned off.
  • ALLOW_REPEAT (on): This is an important part of the UI, and there should be no reason to turn it off.
  • CAPITALIZE_USER_NAME (on): No reason at all to have this as an option.

Other issues in config.h:

  • GJW_RANDART is still present in the ANGBAND_LITE block even if it has been removed.
  • MONSTER_FLOW_DEPTH doesn't belong in this file.
  • A comment on why Macs and Windows machines doesn't handle signals would also be welcome.

Change History (5)

comment:1 Changed 10 years ago by takkaria

  • Description modified (diff)

comment:2 Changed 10 years ago by takkaria

  • Keywords config.h options removed

comment:3 in reply to: ↑ description ; follow-up: Changed 10 years ago by takkaria

Replying to CJNyfalt:

  • SAFE_SETUID & SAFE_SETUID_POSIX (on): See my post on the forum some days ago.

See that forum thread for more info on this.

  • ALLOW_AUTOROLLER (on): There are variants where the game won't even compile if this one is turned off.

The autoroller's going anyway, next version, so I don't see any harm with it being there either way.

  • ALLOW_REPEAT (on): This is an important part of the UI, and there should be no reason to turn it off.
  • CAPITALIZE_USER_NAME (on): No reason at all to have this as an option.

Agreed.

Other issues in config.h:

  • GJW_RANDART is still present in the ANGBAND_LITE block even if it has been removed.
  • MONSTER_FLOW_DEPTH doesn't belong in this file.
  • A comment on why Macs and Windows machines doesn't handle signals would also be welcome.

I have no idea why they don't, actually, since I think they probably should...

comment:4 in reply to: ↑ 3 Changed 10 years ago by CJNyfalt

Replying to takkaria:

Replying to CJNyfalt:

  • SAFE_SETUID & SAFE_SETUID_POSIX (on): See my post on the forum some days ago.

See that forum thread for more info on this.

Just a note that I took a look and added something you missed to the thread.

comment:5 Changed 10 years ago by takkaria

  • Resolution set to fixed
  • Status changed from new to closed

see [6a1519e] (SVN r199) and [2364091] (SVN r200).

Note: See TracTickets for help on using tickets.