Opened 7 years ago

Closed 7 years ago

#1596 closed bug (fixed (in v4))

Artifact knowledge menu lists never found artifacts

Reported by: myshkin Owned by: myshkin
Milestone: v4 Keywords: recall
Cc:

Description

Derakon reported this behavior on oook. The attached save file has only six actually found artifacts, but a number more show up in the knowledge menu (e.g. Pair of Sandals of Gwildais).

Change History (2)

comment:1 Changed 7 years ago by myshkin

  • Owner set to myshkin
  • Status changed from new to assigned

Savefile is here. (Attachments seem to be broken currently.) What I reported on IRC:

For at least one instance of the artifact knowledge bug, here is what happens. The artifact has been created, but never seen. In artifact_is_known(), the filter function for choosing which artifacts to display in the knowledge menu, that it's been created allows it to pass one test, and then find_artifact() fails to find the artifact, and so everything falls through to the default of TRUE.

I am not sure exactly what the logic is supposed to be, but probably replacing the test for created with a test for seen is sufficient.

That does at least seem to do the right thing on Derakon's savefile.

comment:2 Changed 7 years ago by myshkin

  • Resolution set to fixed (in v4)
  • Status changed from assigned to closed

Fixed in commit f3a5da2.

Note: See TracTickets for help on using tickets.