Opened 10 years ago

Closed 10 years ago

#160 closed bug (fixed (in master))

player_egid needs to be set for all SET_UID systems

Reported by: CJNyfalt Owned by:
Milestone: 3.0.8 Keywords: security pr2
Cc:

Description (last modified by takkaria)

main.c: The player_egid variable needs to be set for all SET_UID code, not just HAVE_SETEGID. The relevant code should read like this:

#ifdef SET_UID

/* Get the user id (?) */
player_uid = getuid();

/* Save some info for later */
player_egid = getegid();

#endif /* SET_UID */

BTW, the comments could also use some cleanup.

Change History (4)

comment:1 Changed 10 years ago by takkaria

  • Description modified (diff)
  • Keywords security added; setgid player_egid bug removed

comment:2 Changed 10 years ago by takkaria

  • Keywords pr2 added

comment:3 Changed 10 years ago by takkaria

see [c133eb8] (SVN r287).

comment:4 Changed 10 years ago by takkaria

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.