Opened 8 years ago

Closed 7 years ago

#1604 closed bug (fixed (in master))

'K' as unignore conflicts with run north in the roguelike keyset

Reported by: nckmccnnll Owned by:
Milestone: 3.4.0 Keywords: keyset squelch
Cc: david20708@…, myshkin

Description (last modified by nckmccnnll)

Actually, all the capital directions as running with the roguelike keys don't work. Was this a deliberate change? This is v4.

Change History (9)

comment:1 Changed 8 years ago by nckmccnnll

  • Description modified (diff)

comment:2 Changed 8 years ago by magnate

  • Keywords keyset squelch added; roguelike, unignore removed

comment:3 Changed 8 years ago by takkaria

  • Status changed from new to pending

comment:4 Changed 8 years ago by takkaria

  • Milestone changed from Triage to 3.4.0

comment:5 Changed 8 years ago by PowerWyrm

Commit 3442ddf85cd26aadc7ac56614110bc0d61519473 dealt partially with the problem. There is also a section in pref.prf where each '.' should be replaced by ',' for all 'C:1' entries:

# Running
A:.1
C:0:{S}[End]
C:1:{S}[End] <-- incorrect, it's A:,1
C:0:{SK}1
C:1:{SK}1 <-- id
C:0:{SMK}[End]
C:1:{SMK}[End] <-- id
...

And for the "stay still" command, the key in the roguelike keyset is '.' not ',':

# Stay still (numerical)
A:, <-- A:.
C:1:5
C:1:{K}5
C:1:{MK}5
C:1:{K}[Begin]
C:1:{MK}[Begin]

comment:6 Changed 8 years ago by myshkin

As I said on IRC, I think PowerWyrm is incorrect in 5 above. The A: line should be the internal command character, not the keyset's keypress, if I understand correctly. Do you have a roguelike keypress that's still interpreted incorrectly? If so, what's the behavior? Otherwise, I think takkaria's and/or david3x3x3's recent changes address this problem.

comment:7 Changed 8 years ago by david3x3x3

  • Cc david20708@… added

comment:8 Changed 8 years ago by takkaria

  • Cc myshkin added

myshkin, this changed recently. When I fixed a lot of the roguelike key bugs, I removed the distinction between the chosen keyset and the underlying keyset. Keymaps are done in whatever keyset you use. It looks like I didn't update all the pref files appropriately for this change, though.

comment:9 Changed 7 years ago by myshkin

  • Resolution set to fixed (in master)
  • Status changed from pending to closed

Commit 177135a to master changes pref.prf per PowerWyrm?'s comment above. Running in the roguelike keyset works now.

Note: See TracTickets for help on using tickets.