Opened 8 years ago

Closed 8 years ago

#1642 closed bug (fixed (in master))

^J key registers as Enter on Windows

Reported by: david3x3x3 Owned by:
Milestone: Triage Keywords:
Cc:

Description

With the roguelike keyset, pressing control-j is supposed to tunnel in a downward direction, however on Windows it brings up the action menu.

I've attached a patch to fix the issue.

Attachments (1)

control-j-fix.txt (481 bytes) - added by david3x3x3 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by david3x3x3

comment:1 Changed 8 years ago by magnate

Is this not related to #1417? If it is, please could we consolidate and make sure that we address both issues. If it's not, don't mind me.

comment:2 Changed 8 years ago by david3x3x3

16:50 < david3x3x3> magnate[AFK]: i'm not sure about consolidating all these

keyboard issues under #1417

16:50 < david3x3x3> i don't think we've got an overall problem that we're

trying to address

16:51 < david3x3x3> it's just that the display modules are all making the same

type of errors

16:52 < david3x3x3> if anything, i'd probably break 1417 into separate tickets

for each module

16:52 < david3x3x3> because that's where the fix would have to be
16:53 < david3x3x3> i'm certainly willing to work on these issues, although i'm

not certain of my ability to build on OS X

comment:3 Changed 8 years ago by magnate

Hi David - forgive me, I'm really very ignorant of both the input code and the display code. But it seems to me that if the different modules are having the same types of errors then we *should* be trying to fix them in one place - the fact that the fixes would need to be in separate modules hints to me that we have failed to abstract some input handling out of the modules and into a unified input code segment. Does that make sense? I don't know how extensive such abstraction would become, but I wonder if takkaria had something similar in mind in CoreUiSplit.

comment:4 Changed 8 years ago by david3x3x3

I don't think that we can fix these types of errors in one place. The only option I've heard suggested on IRC was to use a libtermkey library, but that won't work because it would only work with modules that run in Unix terminals (only GCU).

I've made some headway in fixing both this ticket and 1417 over here:

https://github.com/david3x3x3/angband/compare/master...ticket-1417

It seems to be working on windows, x11, gcu. I need to test it on osx and sdl.

comment:5 Changed 8 years ago by fizzix

Fixed by david3x3x3 commits a663506, caf2d3e, 2b99ccb

comment:6 Changed 8 years ago by fizzix

  • Resolution set to fixed (in master)
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.