Opened 7 years ago

Closed 7 years ago

#1644 closed bug (fixed (in v4))

Tidy up slays

Reported by: magnate Owned by: magnate
Milestone: v4 Keywords: combat
Cc:

Description

The resurrection of http://angband.oook.cz/forum/showthread.php?t=5371 has caused me to find some nasty bugs in the v4 slay code - which will need fixing independent of the archery and info stuff.

  1. There is cruft in attack.c because mult is no longer needed there - it should be dealt with in calc_damage.
  1. But there's a problem, because the slay_mult array doesn't add a % for the HURT_ flags. I think I originally thought this would be done outside the slay code, back in attack.c, but it can't, because the whole point is that calc_damage returns the total damage, it can't then be broken down into chunks for a HURT_ increment to be applied to base_dam.
  1. object_slay_mults sets the mult array value to -1 if the HURT_ flag is present - but this is immediately reset to 0 because 0 > -1!

I think the solution is to set the mult to 100 for these, but needs careful checking.

Change History (1)

comment:1 Changed 7 years ago by magnate

  • Resolution set to fixed (in v4)
  • Status changed from new to closed

[ea27dff] and the two preceding commits.

Note: See TracTickets for help on using tickets.