Opened 8 years ago

Closed 8 years ago

#1670 closed bug (fixed (in master))

EF_STAFF_HOLY does not do what its description says

Reported by: myshkin Owned by:
Milestone: 3.4.0 Keywords: magic text


Description: "inflicts damage on evil creatures you can see, cures 50 hit points, heals all temporary effects and grants you protection from evil"

(As srd_ notes, we should probably swap "cures" and "heals" here regardless.)

Code: STAFF_HOLY only clears TMD_POISONED, TMD_AFRAID, TMD_STUN, and TMD_CUT. It does not affect TMD_SLOW, TMD_BLIND, TMD_PARALYZED, TMD_CONFUSED, or TMD_IMAGE; of course, TMD_PARALYZED doesn't make sense here.

How should we fix this?

Change History (5)

comment:1 Changed 8 years ago by myshkin

From IRC:

Derakon: Myshkin: make it a super-Staff of Curing, IMO.
Derakon: So it should clear all bad timered effects.

comment:2 Changed 8 years ago by myshkin

From IRC:

d_m: myshkin: re 1670, i agree with Derakon
d_m: given that it currently is pretty bad, i'd say make it good. if it's too good we'll hear about it

comment:3 Changed 8 years ago by magnate

Agreed - let's have it clear confusion, hallucination, slowing and blindness too.

comment:4 Changed 8 years ago by myshkin

My initial list omitted TMD_TERROR and TMD_AMNESIA. I should also note that more generally we have a whole host of effects that clear some subset of negative status effects, and most of them do something slightly different. effects.c could use some refactoring. I think that's more for 3.5, though.

comment:5 Changed 8 years ago by noz

  • Resolution set to fixed (in master)
  • Status changed from new to closed

Fixed in c2abc5f by myshkin

Note: See TracTickets for help on using tickets.