Opened 7 years ago

Closed 7 years ago

#1680 closed bug (fixed (in master))

Error in pickup message when squelch items are present

Reported by: fizzix Owned by:
Milestone: 3.4.1 Keywords:
Cc:

Description

If there is a stack on the ground that contains one squelched (invisible) item and one unsquelched item, the game does not display the expected interface when attempting to pick up the item. When you pick up the item you are prompted "which item" even though only one item is present. After picking up the item you are shown the message, "You see nothing there."

Correct behavior, no prompt if there is only one unsquelched item in a stack. No message after picking up the item.

Change History (4)

comment:1 Changed 7 years ago by fizzix

  • Milestone changed from Triage to 3.4.1

comment:2 follow-up: Changed 7 years ago by PowerWyrm

I checked the pull request submitted to fix this and this clearly doesn't work (at least it breaks the change made to fix #1665).

The proper fix is to add a new mode for scan_floor and split the 0x02 mode in two: add 0x08 for marked items and keep 0x02 for squelched items. In this case, the fix (with 0x02) works when picking things up. The only thing to do is check all other calls to scan_floor and replace 0x02 by 0x0A.

comment:3 in reply to: ↑ 2 Changed 7 years ago by fizzix

Replying to PowerWyrm:

The proper fix is to add a new mode for scan_floor and split the 0x02 mode in two: add 0x08 for marked items and keep 0x02 for squelched items. In this case, the fix (with 0x02) works when picking things up. The only thing to do is check all other calls to scan_floor and replace 0x02 by 0x0A.

#1665 is still broken for unmarked objects, but it seems to work ok if you know the object is there.

comment:4 Changed 7 years ago by magnate

  • Resolution set to fixed (in master)
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.