Opened 6 years ago

Closed 6 years ago

#1772 closed bug (fixed (in master))

Lore fixes

Reported by: PowerWyrm Owned by:
Milestone: 3.5.0 Keywords:
Cc:

Description

In mon-lore.c:

  • OF_RES_SOUND only protects against sound attacks now; in get_attack_colors(), force, plasma and water shouldn't check for that flag
  • OF_RES_STUN is not checked; attacks that stun (sound, gravity, force, plasma, water, ice) should check that flag in get_attack_colors() and display a "meaner" color if not resisted
  • cheat_monster_lore() doesn't increment l_ptr->drop_item for RF_DROP_20

Change History (4)

comment:1 Changed 6 years ago by PowerWyrm

Also:

  • in lore_append_toughness(), the chance to hit a monster has not been updated (see test_hit() in attack.c): "race->ac / 2" should be "race->ac * 2 / 3"

comment:2 Changed 6 years ago by takkaria

  • Milestone changed from Triage to 3.5.0
  • Resolution set to fixed (in master)
  • Status changed from new to closed

Fixed in dfad37.

comment:3 Changed 6 years ago by PowerWyrm

  • Resolution fixed (in master) deleted
  • Status changed from closed to reopened

My bad: OF_RES_SOUND now protects against any side-effect from sound attacks. The color should be: green if OF_RES_SOUND, yellow if OF_RES_STUN but no OF_RES_SOUND, orange otherwise.

comment:4 Changed 6 years ago by takkaria

  • Resolution set to fixed (in master)
  • Status changed from reopened to closed

Fixed in 223cdad

Note: See TracTickets for help on using tickets.