Opened 6 years ago

Closed 5 years ago

#1810 closed bug (fixed (in master))

./configure should check for rst2html

Reported by: Aerdan Owned by:
Milestone: 3.5.1 Keywords:
Cc:

Description

./configure should check for rst2html and disable building of HTML documentation if not present. Currently, it just stops installation.

Change History (6)

comment:1 Changed 5 years ago by takkaria

  • Milestone changed from Triage to 3.5.1

comment:2 Changed 5 years ago by noz

Following chunk of configure.ac should do most of it:

AC_ARG_VAR([RST2HTML], [command for converting reStructuredText to HTML])
AC_CHECK_PROGS([RST2HTML], [rst2html.py rst2html], [NOTFOUND])
AM_CONDITIONAL([HAVE_RST2HTML], [test NOTFOUND != "$RST2HTML"])

if test NOTFOUND = "$RST2HTML"
then
  AC_MSG_NOTICE([rst2html not found; HTML version of manual will not be built])
fi

comment:3 Changed 5 years ago by magnate

  • Status changed from new to confirmed

comment:4 Changed 5 years ago by noz

Given that this only occurs on "make manual", I don't think that configure should print a warning if it's not there. Maybe a warning in the Makefile, if HAVE_RST2HTML is not set, and you try "make manual"?

comment:5 Changed 5 years ago by Aerdan

Yes, but make manual also produces a PDF version.

comment:6 Changed 5 years ago by magnate

  • Resolution set to fixed (in master)
  • Status changed from confirmed to closed

Fixed in 360a6b8 but see also #1831.

Note: See TracTickets for help on using tickets.