Opened 6 years ago

Closed 3 years ago

#1817 closed bug (fixed (in master))

Random high resists can fail to add anything to ego items

Reported by: Derakon Owned by:
Milestone: 4.1 Keywords: items
Cc:

Description

From IRC:

(08:15:57 PM) Derakon: Hm, shields of Preservation are supposed to have a random high resist, aren't they?
(08:15:57 PM) Derakon: I just found one that only had rDis.
(08:15:57 PM) Derakon: I wonder if the randomly-chosen high resistance was disenchantment?
(08:45:27 PM) Derakon: Yeah, to the best of my ability to read the code, a cursory inspection says there's no check to make certain that "add a random high resist" actually does anything.

Change History (3)

comment:1 Changed 5 years ago by PowerWyrm

This can happen to any ego with random high/ability that already has a fixed high/ability. Currently, Angband has two more ego items impacted: Gondolin (free action + see invisible + random ability), and Lothlorien (free action + random ability).

comment:2 Changed 4 years ago by nckmccnnll

  • Milestone changed from Triage to 4.1

Fix in 4.1 with ID changes

comment:3 Changed 3 years ago by nckmccnnll

  • Resolution set to fixed (in master)
  • Status changed from new to closed

Closing this, I believe that random_high_resist() now avoids existing resists, and get_new_attr() always did the right thing for abilities.

Note: See TracTickets for help on using tickets.