Opened 4 years ago

Closed 3 years ago

#1828 closed bug (wontfix)

Manually targeting a square should target any target_able monster

Reported by: PowerWyrm Owned by:
Milestone: 4.0 Keywords:
Cc:

Description

When use_old_target is set to "yes" and you aim a wand of teleport other at a monster, the next time you aim the wand it uses up a charge but does nothing else. I guess it's because the target is still set to the now out-of-LOS teleported monster.

Probably related to #332.

Change History (5)

comment:1 Changed 4 years ago by PowerWyrm

  • Summary changed from Apply use_old_target only if the monster is in LOS to Manually targeting a square should target any target_able monster

In fact this happens when using manual targeting (p) on a square with a monster. The game now records the coordinates instead of the monster and simply aims at the same square if use_old_target is set.

This is in fact a side effect of fixing #1792. On my local copy, I don't have this problem, because I fixed #1792 differently (target_set_location):

    /* Legal target */
    if (cave_in_bounds_fully(cave, y, x))
    {
        int m_idx = cave->m_idx[y][x];

        /* Save target info */
        target_set = TRUE;
        target_who = NULL;
        if (m_idx)
        {
            struct monster *mon = cave_monster_at(cave, y, x);
            if (target_able(mon))
                target_who = mon;
        }
        target_y = y;
        target_x = x;
    }

Before commit 61ca4d8, the monster was targeted properly, but the coordinates were not set. Commit 61ca4d8 did set the coordinates properly, but allowed non target_able monsters to be chosen. Commit 4901b95 disallowed any monster to be manually targeted. I think the above fix should work properly by setting the coordinates properly and allowing any target_able monster to be targeted.

comment:2 Changed 3 years ago by nckmccnnll

  • Milestone changed from Triage to 4.0

This looks like it needs fixing

comment:3 Changed 3 years ago by nckmccnnll

  • Resolution set to fixed (in master)
  • Status changed from new to closed

Fix as above applied in d43c3fb

comment:4 Changed 3 years ago by nckmccnnll

  • Resolution fixed (in master) deleted
  • Status changed from closed to reopened

After the discussion referenced in #1946, this was reverted in 19d624f.

comment:5 Changed 3 years ago by nckmccnnll

  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.