Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#269 closed task (fixed (in master))

Sort out "message package"

Reported by: takkaria Owned by: elly
Milestone: 3.3.0 Keywords: cleanup
Cc:

Description (last modified by takkaria)

Nuke message(), message_format(), msg_print(), msg_format().

Add:

  • msgt(type, msg, ...) -> sound(type); msg_print_aux(type, format(msg, ...))
  • msg(msg, ...) -> msg_print_aux(MSG_GENERIC, format(msg, ...)

Regexes to achieve this:

  • s/message\(MSG_GENERIC, 0, ([A-Za-z""]*)/msg(\1)/
  • s/message_format\(MSG_GENERIC, 0, ([A-Za-z"", ]*))/msg(\1)/
  • s/message\(([A-Z_]*), 0, ([A-Za-z""]*))/msgt(\1, \2)/
  • s/message_format\(([A-Z_]*), 0, %%)/msgt(%%, %%)/
  • s/msg_format\((.*))/msg(\1)/
  • s/msg_print\((.*))/msg(\1)/

Change History (7)

comment:2 Changed 10 years ago by takkaria

  • Description modified (diff)

comment:3 Changed 10 years ago by takkaria

  • Keywords cleanup added

comment:4 Changed 10 years ago by andrewdoull

Consider also implementing a text_hook to message redirect, because its probably going to be useful.

I'd like to have long (e.g. greater than term width) messages pop-up in a text-bordered window overlaying the main display, similar to the way the main menu works. This would be useful for really varied term sizes, and quest-givers...

comment:5 Changed 7 years ago by magnate

  • Type changed from bug to task

comment:6 Changed 7 years ago by magnate

  • Milestone changed from 4.0 to 3.3.0
  • Owner set to elly
  • Status changed from new to assigned

comment:7 Changed 7 years ago by magnate

  • Status changed from assigned to pending

In staging as of [c31dc9e]

comment:8 Changed 7 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed

In master as of [480b5ba]

Note: See TracTickets for help on using tickets.