Opened 10 years ago

Closed 10 years ago

#282 closed bug (fixed (in master))

Angband relies on RGB colours in curses port

Reported by: william-mcbrine Owned by:
Milestone: 3.0.9 Keywords: port gcu
Cc:

Description

[7625c26] (SVN r205) was: 'Revert "can has colour" support for PDCurses -- it just messes up colours.'

The problem is that, although the symbolic constants like COLOR_RED are being used in some places, in others, the colors are implicitly treated as RGB, as in ncurses -- where COLOR_RED == 1, COLOR_GREEN == 2, COLOR_BLUE == 4, etc. However, in PDCurses, by default (and for historic reasons), the colors are BGR: COLOR_BLUE == 1, COLOR_RED == 4, etc. (HP-UX curses also uses BGR; most other curses implementations use RGB.)

So, eliminate that assumption. :)

Change History (3)

comment:2 Changed 10 years ago by takkaria

  • Milestone changed from 3.0.9 to 3.0.8fix1

comment:3 Changed 10 years ago by takkaria

  • Resolution set to fixed
  • Status changed from new to closed

see [380] merged in [5dfe994] (SVN r399).

Note: See TracTickets for help on using tickets.