Opened 10 years ago

Closed 9 years ago

#333 closed change (worksforme)

Fixes for window positions in main-x11

Reported by: morth@… Owned by:
Milestone: 3.1.0 Keywords: close-jan
Cc:

Description

I've had a fix for the moving windows sitting on my comp for a while. Since I noticed a workaround had been added to 3.0.9, it came back to me, and here it is. The disclaimer is I've not tried it on any other WM than quartz-wm (which did have the moving windows problem).

It also contains a new -x option for choosing the name of the x11-settings.prf file to load. Useful when I play both from work (on my break ofc :)) and home.
And finally it properly tells the WM that the window positions were chosen by the user. This forces (well, strongly recommends anyway) the WM to use the position specified, instead of thinking it knows better.

Attachments (3)

angband_moving_windows.diff (6.1 KB) - added by morth@… 10 years ago.
diff
angband_x11_x.diff (4.1 KB) - added by morth@… 10 years ago.
patch for -x and setting USPosition (user set window position) only.
angband_term_wins.diff (616 bytes) - added by morth@… 10 years ago.

Download all attachments as: .zip

Change History (15)

Changed 10 years ago by morth@…

diff

comment:1 follow-up: Changed 10 years ago by morth@…

Sorry seemed I removed the -s option from the usage line by mistake. Please ignore that diff line.

comment:2 in reply to: ↑ 1 Changed 10 years ago by anonymous

Replying to morth@morth.org:

Sorry seemed I removed the -s option from the usage line by mistake. Please ignore that diff line.

bah, no, it was just moved, so it should be applied. I'll try to shut up now. :p

comment:3 Changed 10 years ago by takkaria

This patch doesn't seem to work with the default WM on Ubuntu or Debian, so I'm not putting it in, though I appreciate the patch. If you want to make a seperate patch so -x loads a prefile, I'll happily accept that, though.

comment:4 Changed 10 years ago by morth@…

Hrm, ok. Maybe I can fire up Ubuntu and give it a second try... Was the behaviour the same as without the patch or different?

Changed 10 years ago by morth@…

patch for -x and setting USPosition (user set window position) only.

comment:5 Changed 10 years ago by takkaria

Same as without, I think. Going to apply the patch you attached now.

comment:6 Changed 10 years ago by takkaria

Applied. If you have any more thoughts on the matter, they'd be welcome. If not, then I'll close this bug in a few days.

comment:7 Changed 10 years ago by takkaria

  • Keywords waiting added

comment:8 Changed 10 years ago by morth@…

I think you can close it. I might make another try at the moving windows, but probably not until in a few months the earliest.
The comment in [e9ef03e] (SVN r517) is not correct however. The USPosition flag is to force the WM to use the position given by the program, instead of putting the window at the default position. I guess most WMs put windows at the given position even without it, but mine doesn't. It doesn't help the drifting windows whatsoever.

comment:9 Changed 10 years ago by morth@…

Apparently I messed up the saving of TERM_WINS by saving the value before it was set... Attaching a fix.

Changed 10 years ago by morth@…

comment:10 Changed 10 years ago by takkaria

  • Milestone changed from 3.2.0 to 3.1.0

comment:11 Changed 9 years ago by takkaria

  • Keywords close-jan added; waiting removed

The patch attached doesn't seem like it should do anything -- the number of terminal windows isn't altered at all between the place the moved statement is at pre-patch and the place it's at post-patch. Closing in January unless there's anything else you have to add here.

comment:12 Changed 9 years ago by takkaria

  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.