Opened 12 years ago

Closed 11 years ago

#552 closed bug (fixed (in master))

Highscores busted

Reported by: takkaria Owned by: takkaria
Milestone: 3.1.0 Keywords:
Cc:

Description

See discussion at
http://angband.oook.cz/forum/showthread.php?t=662

It would be good to just rewrite this code, I think.

Attachments (1)

score.diff (22.4 KB) - added by takkaria 12 years ago.
First go at fixing this up

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by takkaria

  • Owner set to takkaria
  • Status changed from new to assigned

Changed 12 years ago by takkaria

First go at fixing this up

comment:2 Changed 12 years ago by takkaria

Attached is a patch which is a significant rewrite of the scorefile handling code. Instead of making use of file-seek and incremental reading operations, it instead prefers to read all highscores into a buffer of 12.5kB, operate with the data entirely in memory, and then write it out (if necessary).

This simplifies an amount of code. As a result of this, the logic code that deals with writing the scorefile is more clearly visible and has had several corrections.

Another good thing about this code is also that it will make future modifications to the highscore format really very easy.

comment:3 Changed 11 years ago by takkaria

  • Resolution set to fixed
  • Status changed from assigned to closed

see [0cae08a] (SVN r965)

Note: See TracTickets for help on using tickets.