Opened 11 years ago

Closed 8 years ago

#558 closed bug (fixed (in master))

Vaults don't have good objects

Reported by: ChodTheWacko Owned by:
Milestone: 3.2.0 Keywords: items
Cc:

Description

Noted in the newsgroup -
Caused by the changes to make_object in revision 404.

You really want:

do
{

/* Pick a random object */

#if 0

k_idx = get_obj_num(base, kind_is_good);

#else

k_idx = get_obj_num(base);

#endif

/* Keep if it's good, or try again */
if (kind_is_good(k_idx)) break;

} while (good)

so that if the good flag is passed in via VAULT drop, or a 'good' flagged
monster drop, that you are guaranteed a good object.

as it stands now, with the good/great flag, it just tries 3/5 times and settles for whatever after that.

Change History (2)

comment:1 Changed 10 years ago by magnate

  • Keywords items added

comment:2 Changed 8 years ago by magnate

  • Milestone changed from 4.0 to 3.2.0
  • Resolution set to fixed
  • Status changed from new to closed

make_object has moved on quite a bit, and fizzix's vault changes in 3.2 have also helped resolve this problem. Closing until someone complains about poor objects in vaults ...

Note: See TracTickets for help on using tickets.