Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#56 closed task (fixed (in master))

Make squelch simpler and cleaner

Reported by: takkaria Owned by: takkaria
Milestone: 3.0.8 Keywords: ui
Cc:

Description (last modified by takkaria)

Basically, simplify a lot so it's no longer confusing, and make it work for mouse users. See comments for more details.

Change History (14)

comment:1 Changed 10 years ago by takkaria

  • Status changed from new to assigned

I think I'm going to significantly alter the patch after playtesting. It's too complex, and the UI is horrible.

  • add an option "autopickup things that match inventory"
  • add the ability to mark any given object as "destroy on sight"/"always pickup" (=k, =g autoinscriptions, probably)
  • remove the current interface for individual items, use the knowledge one instead
  • quality-based "destroy weapons/missiles/armour" on pseudo-id (works in pack, as current implementation, almost)

comment:2 Changed 10 years ago by pmac

I made a first hack at the Quality Squelch menu using the new menu API. It is infinitely simpler code; I don't know if the interface is better, although it is now usable with just a mouse.

comment:3 Changed 10 years ago by takkaria

Quote:

Since quality squelch doesn't get saved between characters anyway, I'm going to make things easier by removing the attempt to work for both weak- and strong- pseudo-id characters, and just have it use whichever one the current character has.

comment:4 follow-up: Changed 10 years ago by takkaria

  • priority changed from normal to blocker

comment:5 Changed 10 years ago by takkaria

  • Type changed from feature to task

comment:6 in reply to: ↑ 4 Changed 10 years ago by pmac

Replying to takkaria:
Disagree. Strong-pseudo has real meaning for weak-pseudo characters. Better to just get rid of weak pseudo of "good" items, which is basically the same as squelch-all-but-artifacts. More useful is squelch cursed-but-not-worthless, which allows you to keep Bows of the Nazgul (for SI) but squelches all ordinary cursed bows.

comment:7 Changed 10 years ago by pmac

  • component changed from Maintenance to UI

comment:8 Changed 10 years ago by takkaria

  • Description modified (diff)
  • Summary changed from Clean up the squelch patch to Make squelch simpler and cleaner

comment:9 Changed 10 years ago by takkaria

  • Description modified (diff)

comment:10 Changed 10 years ago by takkaria

  • Description modified (diff)

comment:11 Changed 10 years ago by takkaria

  • component changed from Interface to Main game
  • Keywords ui added

comment:12 Changed 10 years ago by takkaria

  • Description modified (diff)

Done today (will upload patch tomorrow):

Stop squelching items in the pack without choice. Mark items as {squelch} instead of actually being squelched, Ey-style. Auto-mark items as squelch when we find out they're bad (e.g. potions). 'k!' should bring up a menu of just the items to be squelched, to confirm, before hitting "y". Inscribing an item "!k" will rescue it from being squelched.

"Merge inscriptions" option should be always-on.
"Verify destruction" option should be always-on.

Remove chest squelching. Remove ego-item squelching.
Remove individual item squelch groups for pseudo-id-able items. They are handled using the quality squelch.

Remove item-based autopickup/neverpickup options, instead add:

Always pickup items matching those in inventory : on (pickup_inven)

comment:13 Changed 10 years ago by takkaria

  • Description modified (diff)

Done today (quality squelch screen not quite working fully yet, though):

Move all menus across to the new menu API -- possibly adding "multicolumn" menu display.

Simplify the quality squelch screen to give fewer options. A simple choice of weapons/missiles/armour/lights/etc rather than the massive number of subchoices will still be fine. Remove the crazy "all items" and "just this item" code, make the changes work on a per-group basis.

comment:14 Changed 10 years ago by takkaria

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from assigned to closed

in [05e0dac] (SVN r156). +667 lines, -1379 lines, -712 net.

Note: See TracTickets for help on using tickets.