Opened 10 years ago

Last modified 22 months ago

#659 confirmed task

Get valgrind reporting that all memory is properly freed at game exit

Reported by: takkaria Owned by:
Milestone: Ongoing Keywords: cleanup
Cc: myshkin

Description


Change History (13)

comment:1 Changed 10 years ago by morth

Why do this? I can't see any other result than slowing down the game exit and potentially introducing bugs. Pure leaks is one thing, but reachable at exit is seldom useful to go after.

comment:2 follow-up: Changed 10 years ago by takkaria

It's mostly useful so we know that the game is actually watertight when it comes to trying to allow loading savefiles after death without restarting.

comment:3 Changed 10 years ago by takkaria

  • Milestone changed from 3.1.1 beta to 3.1.2 beta

comment:4 Changed 10 years ago by magnate

  • Keywords cleanup added

comment:5 in reply to: ↑ 2 Changed 9 years ago by anonymous

Replying to takkaria:

It's mostly useful so we know that the game is actually watertight when it comes to trying to allow loading savefiles after death without restarting.

Also the borg will appreciate this.

comment:6 Changed 8 years ago by magnate

  • Milestone changed from 3.2.0 to 3.3.0

Punting to 3.3 as an elly to-do ...

comment:7 Changed 8 years ago by magnate

  • Milestone changed from 3.3.0 to Future
  • Status changed from new to confirmed

Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).

comment:8 Changed 8 years ago by magnate

Lots of progress on this due to the colossal memory overhead of -mstats (see #786). Latest remaining issues are at ​http://www.terminalarrogance.com/valgrind4.txt

comment:9 Changed 8 years ago by magnate

Some suggestions from Blue Baron: ​http://angband.oook.cz/forum/showthread.php?p=54632#post54632

comment:10 Changed 8 years ago by takkaria

those issues would never have come up under valgrind, sadly (they're windows only) but fixed now, as of [5699796]

comment:11 Changed 5 years ago by myshkin

  • Cc myshkin added

I guess we should look at this again before 3.5 release. (Mostly adding this comment to test e-mail notification. Sorry for the spam.)

Last edited 5 years ago by myshkin (previous) (diff)

comment:12 Changed 5 years ago by myshkin

3.5 is pretty clean, with the caveat that random wandering around doesn't exercise the whole codebase.

comment:13 Changed 22 months ago by nckmccnnll

  • Milestone changed from Future to Ongoing

Moving this to Ongoing, because it is a thing that just needs doing from time to time

Note: See TracTickets for help on using tickets.