Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#710 closed bug (wontfix)

Should ESP radius be rectangular, like the detection area?

Reported by: takkaria Owned by:
Milestone: 3.1.1 beta Keywords:
Cc:

Description


Attachments (2)

circle-detection.patch (8.8 KB) - added by rhinocesaurus 10 years ago.
Changed all detection and mapping spells from 81x45 rectangle to radius 32 circle.
rect-telepathy.patch (2.1 KB) - added by rhinocesaurus 10 years ago.
Ok, this patch makes ESP rectangular. Moved the rectangular detection constants to defines.h, hope that's the best place to put them - I'm new at this.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by magnate

No - detection radius should be circular, like ESP .... ;-)

Changed 10 years ago by rhinocesaurus

Changed all detection and mapping spells from 81x45 rectangle to radius 32 circle.

comment:2 Changed 10 years ago by Big Al

IIRC, detection radii were changed to circular, but then changed back because rectangles overlap better (err, that is to say, they don't overlap as much). A 32-radius circle may be about the same size as a 81x45 rectangle, but it takes many more casts to cover the whole dungeon with a circle. I would go with the original suggestion, if at all.

comment:3 Changed 10 years ago by magnate

But you don't need to cover the whole dungeon. If anyone feels a compulsion to clear levels, that's fine, but we don't need rectangular radii just for that case. Circular radii just feel better on so many levels ... I really hope Takkaria implements this patch

comment:4 Changed 10 years ago by takkaria

What Big Al said— I did use circular detection areas for a while, but in the end found just using a fixed-size rectangle was less annoying. While a circle makes more sense, rectangles play better, because it's far easier to tessellate them. (Hence this bug being about moving ESP to being rectangular, like the other detect things, rather than the detections being moves to circular.)

comment:5 Changed 10 years ago by anonymous

When it doubt, make it a birth option!
I think that the detection size should get modified.
make the baseline from how strong/rare the spell/magic item is, and then modify with levels and spellcasting stat. even the durability could come into play, scroll of trap detection > staff > rod.

Changed 10 years ago by rhinocesaurus

Ok, this patch makes ESP rectangular. Moved the rectangular detection constants to defines.h, hope that's the best place to put them - I'm new at this.

comment:6 Changed 10 years ago by d_m

  • Resolution set to wontfix
  • Status changed from new to closed

OK, so it seems like based on discussions with takkaria and lispy on IRC that it's better to leave detection circular (since circular radius is probably "more correct" but square detection areas are convenient). So rather than force consistency we're just going to leave it alone and close this issue.

rhinocesarus: Thanks for both patches, and sorry that they won't be committed.

comment:7 Changed 10 years ago by d_m

Err... that is, leave ESP circular and detection rectangular.

Note: See TracTickets for help on using tickets.