Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#794 closed bug (fixed (in master))

Artifact spoiler does not list slays/brands on weapons

Reported by: magnate Owned by:
Milestone: 3.1.1 beta Keywords:
Cc:

Description

The artifact spoiler (ctrl-a, ", 2) does not show slays or brands on weapons. This is due to the way object_info_out works in src/object/obj-info.c - brands and slays are dealt with in describe_combat, which is not called by object_info_out.

I suggest splitting brands and slays out of describe_combat into a separate describe_slays, which can then be called by both object_info_out and describe_combat.

I'm happy to do this if the idea is acceptable.

CC

Attachments (2)

215-fix-spoilers.patch (2.1 KB) - added by magnate 11 years ago.
patch to fix this problem
216-fix-plusses.patch (1.4 KB) - added by magnate 11 years ago.
fix for missing plusses in artifact spoiler

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by magnate

Actually no, I don't think we need to touch describe_combat at all. We just create a function called describe_slays which calls collect_slays and then formats the text, and we call this in object_info_out. Will test.

Changed 11 years ago by magnate

patch to fix this problem

comment:2 Changed 11 years ago by magnate

Ok, done. I can't log in yet so I can't close this myself, but it can now be closed.

comment:3 Changed 11 years ago by magnate

Ok, having fixed one problem, I noticed another: the artifact spoiler no longer prints plusses to hit and damage on weapons. This has its roots in the same issue (these numbers are dealt with in describe_combat, which is not called by object_info_out).

I'll update the patch, so don't use it yet.

CC

Changed 11 years ago by magnate

fix for missing plusses in artifact spoiler

comment:4 Changed 11 years ago by magnate

Now it really can be closed - the artifact spoilers are fully functional.

comment:5 Changed 11 years ago by magnate

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 11 years ago by takkaria

fixed in [211c6e5] (SVN r1229)

Note: See TracTickets for help on using tickets.