Opened 10 years ago

Closed 10 years ago

#831 closed bug (fixed (in master))

Rewrite or remove self_knowledge()

Reported by: magnate Owned by: magnate
Milestone: 3.1.2 beta Keywords: cleanup magic
Cc:

Description

Per discussion on #angband-dev. The self_knowledge() function is currently written in a way that makes it impossible to re-use other useful bits of code (like slay_table etc). In gameplay terms, self-knowledge is vastly less useful since the removal of *ID*. It's a candidate for removal altogether ...

Change History (5)

comment:1 Changed 10 years ago by magnate

Potions of s_k were removed in [78b8145] (SVN r1412). The function is still called by potions of *enlightenment*, and from the knowledge menu (~). See #845 for full details of removal.

comment:2 Changed 10 years ago by magnate

  • Keywords cleanup magic added

comment:3 Changed 10 years ago by magnate

  • Owner set to magnate
  • Status changed from new to assigned
  • Type changed from task to bug

This is now slightly more urgent due to brands and slays on things other than melee weapons and ammo - see http://angband.oook.cz/forum/showthread.php?p=22188#post22188

At the moment the self_knowledge function considers all flags together, regardless of where they come from. So it will say "Your weapon burns your foes" for any of a weapon of flame, a ring of flame and a wielded torch. It will also say "Your weapon is especially deadly against dragons" if you are wielding a normal dagger and Bard.

I'm inclined to remove it altogether, if Takkaria agrees.

comment:4 Changed 10 years ago by magnate

Ok, I am going to remove this as per http://angband.oook.cz/forum/showthread.php?t=2144

(Takkaria can always undo the commit if he feels strongly.)

comment:5 Changed 10 years ago by magnate

  • Resolution set to fixed
  • Status changed from assigned to closed

[6dee137] (SVN r1637)

Note: See TracTickets for help on using tickets.