Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#856 closed bug (fixed (in master))

Shop shouldn't honour keymaps

Reported by: KZK Owned by: takkaria
Milestone: 3.3.0 Keywords: stores InputRework
Cc:

Description (last modified by takkaria)

Macros no longer exist so that's good, but keymaps still work in shops, as long as they are mapped to the keys wtkPbI{}~ or D. This needs fixing.

Change History (7)

comment:1 Changed 9 years ago by magnate

  • Keywords stores added

comment:2 Changed 9 years ago by magnate

  • Milestone changed from Triage to Future

Milestone set per #121

comment:3 Changed 8 years ago by magnate

  • Keywords InputRework added
  • Milestone changed from Future to 3.3.0
  • Owner set to takkaria
  • Status changed from new to assigned
  • Summary changed from Shop text overrun to Shop honours macros

Assuming that the text formatting issue is now part of #121 and this ticket is about macros and keymaps in stores. Keymaps are currently ignored in stores, but macros are not. I agree that macros should be ignored also. takkaria says that macros should be unnecessary after InputRework is finished ...

comment:4 Changed 8 years ago by takkaria

  • Description modified (diff)
  • Summary changed from Shop honours macros to Shop shouldn't honour keymaps

OK

comment:5 Changed 8 years ago by takkaria

  • Description modified (diff)

In the short term: I think we're best just mapping these keys directly to the relevant UI functions.

OK, so in the long term the UI should find out what keys correspond to various bare actions (e.g. wtkPbI{}~) and ensure that they are usable in the stores and are not duplicated as menu items. This will be a bit difficult and isn't achiveable for 3.3, so I'll do the short-term fix and then punt to 3.4.

comment:6 Changed 8 years ago by takkaria

  • Status changed from assigned to pending

in staging, 7de6f5d727

comment:7 Changed 8 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed

In master as of [r5c8f16e]

Note: See TracTickets for help on using tickets.