Opened 8 years ago

Last modified 5 years ago

#869 assigned change

Check and revise monster power algorithm

Reported by: magnate Owned by: magnate
Milestone: v4 Keywords: cleanup
Cc:

Description

While working on [57756ec] (SVN r1415) I thought it would be good to list visible monsters in descending order of power, regardless of depth. This immediately revealed a need to take a good look at the current monster power calculation, because the ordering made no sense whatsoever:

snaga (power 28)
uruk (power 24)
orc shaman (power 4)

So the snaga's power needs fixing at least, and possibly others. I'll start by printing out everything's power and having a look for outliers.

Change History (11)

comment:1 Changed 8 years ago by magnate

  • Status changed from new to assigned

comment:2 Changed 8 years ago by magnate

  • Keywords cleanup added

comment:3 Changed 7 years ago by magnate

  • Milestone changed from 3.1.2 beta to 3.1.3

comment:4 Changed 6 years ago by magnate

  • Milestone changed from 3.2.0 to 4.0

Not a bug or refactor: punting to 4.0

comment:5 Changed 6 years ago by magnate

  • Milestone changed from 4.0 to 3.4.0

comment:6 Changed 6 years ago by magnate

  • Type changed from bug to change

comment:7 Changed 6 years ago by magnate

Note to self: don't forget to change compare_monsters() to use monster power when this is done.

Someone on Oook did some really good work on this, but it was in the pre-git era and needs retrieving.

comment:8 Changed 6 years ago by magnate

comment:9 Changed 6 years ago by magnate

Nullfame's improvements actually went in in [r520beb7]. While they were a great improvement (after fixing the many overflow errors!), there are still some problems with scaled_power which prevent it from being really useful. Ancalagon and Ungoliant lose far too much from the scaling, so something is not consistent.

comment:10 Changed 6 years ago by magnate

As well as fixing scaled_power, we need to address side effects separately from damage (see #1437). In particular, stunning is not properly rated, as 10d1 attacks are far more deadly than 4d4 attacks which have higher maximum damage.

comment:11 Changed 5 years ago by magnate

  • Milestone changed from 3.4.0 to 4.0

Initial assignment to v4 per http://trac.rephial.org/roadmap

Note: See TracTickets for help on using tickets.