Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#954 closed change (fixed (in master))

Ring of Damage display.

Reported by: Tragny Owned by: MarbleDice
Milestone: 3.1.2 beta Keywords: items
Cc:

Description

Rings of Damage should only display the damage enchantment and hide the always +0 to-hit value to be consistent with Rings of Accuracy.

Change History (11)

comment:1 Changed 10 years ago by magnate

  • Keywords items added

comment:2 Changed 10 years ago by KZK

Rings of Damage and Accuracy are both just specialized cases of rings of Slaying. They should both display (+0,+x) or (+x,+0), respectively.

comment:3 Changed 9 years ago by MarbleDice

  • Resolution set to fixed
  • Status changed from new to closed

[25d72b9] (SVN r1743). Seems like consistency would be the best choice, so anything with combat pluses will show the full tuple (+h,+d).

comment:4 Changed 9 years ago by MarbleDice

  • Resolution fixed deleted
  • Status changed from closed to reopened

[78a5b5d] (SVN r1749) changes this again. Currently, a single number is shown for body armor that has only a to-hit penalty. Any body armor with a to-hit bonus or a to-dam adjustment, or any other item with a to-hit or to-dam adjustment gets the full (+h,+d) set.

Re-opening for confirmation that this is the ideal behavior.

comment:5 Changed 9 years ago by MarbleDice

  • Owner set to MarbleDice
  • Status changed from reopened to assigned

comment:6 Changed 9 years ago by magnate

Yep, I think this is right.

comment:7 follow-up: Changed 9 years ago by KZK

"Currently, a single number is shown for body armor that has only a to-hit penalty."

Why this is wrong is because with a single number the player can't tell which (hit or damage) it is.

comment:8 in reply to: ↑ 7 Changed 9 years ago by magnate

Replying to KZK:

"Currently, a single number is shown for body armor that has only a to-hit penalty."

Why this is wrong is because with a single number the player can't tell which (hit or damage) it is.

Except that it has always been this way, and everybody knows which it is, and it's entirely intuitive that heavy armour makes it more difficult to hit things without reducing your damage output. Given that the only alternative is to put (-X,+0) on all body armour, I strongly suggest we stick with this.

comment:9 Changed 9 years ago by KZK

For newcomers who don't actually know that yet. For consistency's sake. Also, I don't see why Heavy armor can't have damage penalties, since in the real world, KE=1/2mV^2, and heavy armor would indeed restrict the velocity of attacks, and hence give a damage penalty.

comment:10 Changed 9 years ago by MarbleDice

  • Resolution set to fixed
  • Status changed from assigned to closed

As far as I know, the only current item affected by this change is the Ring of Accuracy, and the only items that remain exceptions to the (+h,+d) label are most standard armor types. I'm closing this so someone can open another ticket if other anomalies are discovered.

comment:11 Changed 9 years ago by MarbleDice

  • Milestone changed from Future to 3.1.2 beta
Note: See TracTickets for help on using tickets.