Opened 9 years ago

Closed 8 years ago

#979 closed bug (fixed (in master))

Object knowledge menus give away artifact flavours

Reported by: magnate Owned by: noz
Milestone: 3.2.0 Keywords: recall
Cc:

Description (last modified by magnate)

At the moment, all unknown ring and amulet flavours are shown on the object knowledge menus ... except the flavours of artifact rings and amulets. Two possible solutions:

(i) include the artifact ring and amulet flavours in the object knowledge menu

(ii) do not include unseen flavours in the object knowledge menu

I prefer the latter, if they are equally easy to implement. Actually the latter is an extension of the former, not an alternative (an artifact flavour would still need to show up in the menu until it was identified, otherwise it would still obviously be discernible as an artifact).

Change History (6)

comment:1 Changed 9 years ago by magnate

  • Description modified (diff)
  • Status changed from new to confirmed

comment:2 Changed 8 years ago by magnate

  • Owner set to noz
  • Status changed from confirmed to assigned

comment:3 Changed 8 years ago by noz

At the moment, the knowledge menu iterates over "kinds" of object, from k_info[], displaying the object if it's ever been seen, or if it has a flavour.

It has an explicit exception for the INSTA_ART set of artifact kinds. If we drop that exception, then the flavours will show up as per (i) above. However, this will also result in the Phial, Arkenstone, Palantir etc. showing up under lights, and the Necklace / Jewel showing up under amulets. We'll see how that plays.

comment:4 Changed 8 years ago by noz

Fixed in [b74c668] by only removing the artifacts from the list once they are known.

comment:5 Changed 8 years ago by noz

  • Status changed from assigned to pending

comment:6 Changed 8 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed
Note: See TracTickets for help on using tickets.