Changes between Version 13 and Version 14 of NewEgos


Ignore:
Timestamp:
10/13/11 18:09:17 (7 years ago)
Author:
magnate
Comment:

Note to fix unit tests.

Legend:

Unmodified
Added
Removed
Modified
  • NewEgos

    v13 v14  
    8787== Next steps post-merge == 
    8888=== Code cleanup === 
    89 I need to get rid of remaining references to o_ptr->ego and remove it from the object_type struct. Also renaming ego_stuff to affix_stuff would be helpful - I've been a bit lazy about this, in case the whole thing was rejected. I also need to write accessors or #defines for things like AFFIX_IS_PREFIX and so on. 
     89I need to get rid of remaining references to o_ptr->ego and remove it from the object_type struct. Also renaming ego_stuff to affix_stuff would be helpful - I've been a bit lazy about this, in case the whole thing was rejected. I also need to write accessors or #defines for things like AFFIX_IS_PREFIX and so on. I also need to un-break lots of the unit tests! 
    9090 
    9191I'm also wondering whether it's possible/desirable to de-globalise the themes[] and e_info[] arrays, and make them local to obj-make (or wherever). I don't know enough about C to know how important or difficult this would be. Similarly, there are lots of comments in the code about making arrays read-only (e.g. #1202) - again, I'm not sure I really understand this issue properly.