Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#1012 closed change (fixed (in master))

Show build version in dumps

Reported by: magnate Owned by: noz
Milestone: 3.3.0 Keywords: dump
Cc:

Description

At the moment it just says "3.1.2 dev" in dumps, and with ctrl-V. It would be helpful if it said "3.1.1 [ca2973f] (SVN r1767)" or whatever.

Change History (11)

comment:1 Changed 10 years ago by magnate

  • Status changed from new to confirmed
  • Type changed from change to bug

Something odd is going on. It works for some people (http://angband.oook.cz/ladder-show.php?id=9653), but not for others (http://angband.oook.cz/ladder-show.php?id=9639). Could this somehow be platform-dependent??

comment:2 Changed 10 years ago by noz

Yes, it is platform dependent, as this only occurs in Makefile.win:

ifdef BUILD_ID
  CFLAGS += -DBUILD_ID="$(BUILD_ID)"
endif

and the version appearing is dependent on BUILD_ID being defined

comment:3 Changed 10 years ago by noz

How to fix this is highly dependent on release policy. My gut instinct is to make it so that you have to put the version number in a single place, (preferably a revision control tag), and the build tools work from there.

However, I fear that different ways of releasing for different platforms (no use of autotools for Mac, git additions to the svn archive for debian, to name but two), mean that a single solution is impossible. In that case we'll have to rely on manual setting of a variable, as error-prone as that is.

comment:4 Changed 10 years ago by magnate

Hmmm. I'm comfortable that the Debian stuff can sit atop autotools without spoiling things. Can we just use BUILD_ID for autotools, which takes care of Linux and Windows? I don't have a solution for Mac users, but they will remain no worse off than they are now.

comment:5 Changed 9 years ago by magnate

  • Keywords dump added; recall removed
  • Type changed from bug to change

comment:6 Changed 9 years ago by magnate

  • Owner set to magnate
  • Status changed from confirmed to assigned

comment:7 Changed 9 years ago by magnate

  • Milestone changed from 3.2.0 to 3.3.0

Punting to 3.3: non-urgent bug or change.

comment:8 Changed 9 years ago by magnate

  • Owner changed from magnate to noz

comment:9 Changed 9 years ago by magnate

P.S. Takk wants BUILD_ID to include the branch name (or even github url?) as well as the commit - see BetterMake?.

comment:10 Changed 9 years ago by magnate

  • Status changed from assigned to pending

in staging as of [4e64774]

comment:11 Changed 9 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed

In master as of [480b5ba]

Note: See TracTickets for help on using tickets.