Opened 11 years ago

Closed 11 years ago

#1081 closed bug (fixed (in master))

Correct origin text for chest items

Reported by: magnate Owned by: MarbleDice
Milestone: 3.1.2 beta Keywords: recall dump


Currently chest items are shown as dropping at the level of the chest, which is not the level on which the chest was opened. We need to correct either the text or the level used.

Change History (3)

comment:1 Changed 11 years ago by MarbleDice

I would recommend the message "(found in a chest from 1050 feet (level 21))" where the chests impart their origin depth to items inside them. The depth at which you opened the chest is meaningless.

comment:2 Changed 11 years ago by MarbleDice

  • Owner set to MarbleDice
  • Status changed from new to assigned

Got a patch for this, awaiting 3.1.2 release.

Also cleans up some of the origin display code, and adds the depth to acquirement and drops from unknown monsters.

I used items from chests get the origin_depth of the chest they came from. I think that makes the most sense with the limitations of the current system (since "came from a chest dropped by a Hill orc at 1100' (level 22)" would be more trouble than it's worth).

You could also just inherit the origin source as well as the depth, since ultimately a thing from a chest from an orc is a thing from an orc, but somehow that seems incomplete.

comment:3 Changed 11 years ago by MarbleDice

  • Milestone changed from 3.1.3 to 3.1.2 beta
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [a63507b] (SVN r1889)

  • Objects from chests acquire the origin depth of the containing chest
  • Origin depths of 0 feet are shown as found "in town"
  • Added parenthesis to the origin string for objects dropped by monsters
  • Added origin depth for items dropped by unknown monsters and acquirement
Note: See TracTickets for help on using tickets.