Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1149 closed change (fixed (in master))

load of gtk-settings.prf does not accept nonpositive window positions.

Reported by: anonymous Owned by: d_m
Milestone: 3.3.0 Keywords: gtk


Line 1310 in main-gtk.c says (rev. 1967):

if ((td->location.x <= 0) && (td->location.y <= 0)) td->location.x = td->location.y = 100;

I do not see why this is necessary. In fact it is a bug. I want to be able to specify (0,0) (or maybe also (-10,-4)) as the position of my window. I suggest removing this line.

Attachments (1)

main-gtk.c.patch (1.4 KB) - added by anonymous 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by anonymous


comment:1 in reply to: ↑ description Changed 10 years ago by anonymous

It still did not save the window position correctly after exiting the client. There are two kinds of windows in the gtk2 client.
type1:The main window and extra terms.
type2:"Extra" windows which always show messages, equipment, inventory ... (some fixed set)

For type2 the save of the position worked correctly. For type1 it did not. I copied the method for type2 to the method handling type1 (more or less).
This seems to work, patch is attached but I do not fully understand the code.

Anyway the distinction is kind of artificial and should probably planned to be removed in the future.

comment:2 Changed 10 years ago by magnate

  • Keywords gtk added; gtk-client removed
  • Milestone changed from Triage to 3.1.3

comment:3 Changed 10 years ago by magnate

  • Milestone changed from 3.2.0 to 3.3.0

Punting to 3.3: non-urgent bug or change.

comment:4 Changed 10 years ago by magnate

  • Owner set to d_m
  • Status changed from new to assigned
  • Type changed from bug to change

Assigning to d_m per IRC

comment:5 Changed 10 years ago by d_m

  • Status changed from assigned to pending

I have applied the patch. I'm not completely sure what the use cases are, but GTK seems to work after the patch so I'm closing it. It would be great if the anonymous bug reporter could test it.

comment:6 Changed 10 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed

Now in master.

Note: See TracTickets for help on using tickets.