Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1240 closed bug (fixed (in master))

GTK always loads with tiles

Reported by: d_m Owned by:
Milestone: 3.2.0 Keywords: graphics gtk
Cc:

Description

So, I'm not sure if this is a recent addition or just has been broken for awhile, but currently whenever you launch main-gtk, you always get the last tile set.

Change History (5)

comment:1 Changed 10 years ago by magnate

  • Keywords graphics added; tiles removed
  • Milestone changed from Triage to 3.2.0
  • Status changed from new to confirmed

I don't. I always get ascii, even if I use the -g option! So there is a bug somewhere here, but we're not agreed on what it is. Should the game start up as it was last left (with tiles), or should it start in ascii unless you use -g?

comment:2 Changed 10 years ago by magnate

Looking at main-gtk.c, the function init_gtk() parses only two arguments (-n and -i), which is why it ignores -g. No idea why it's auto-loading tiles for you.

The fact that it has completely separate argument-handling code from main.c is appalling. But there is a lot of stuff that needs cleaning up. In the meantime, we could just add -g to this code and turn graphics on if it's present and force ascii if it isn't.

comment:3 Changed 10 years ago by magnate

We now think that gtk-settings.prf is no longer being saved properly, hence d_m always gets tiles and I always get ascii.

So this ticket contains two separate issues: the parsing of -g (which is done in main.c but not in main-gtk.c) and the updating of gtk-settings.prf ...

comment:4 Changed 10 years ago by d_m

  • Status changed from confirmed to pending

This is believed fixed in staging.

comment:5 Changed 10 years ago by magnate

  • Resolution set to fixed
  • Status changed from pending to closed
Note: See TracTickets for help on using tickets.