Allow --with-varpath to override PRIVATE_USER_DIR

[magnate]

On POSIX systems, configure ignores "varpath", even if it is set explicitly. Elly would like to be able to override this behaviour and set a varpath that isn't ~/.angband/Angband.

[magnate]

Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).

[magnate]

It's not configure that ignores varpath, it's in the code itself. Lines 120 and 211 in src/z-file.c both check for SET_UID (or) USE_PRIVATE_PATHS, when this should be && (and) I think.

[noz]

I'm intending to make USE_PRIVATE_PATHS get set by default, unless --with-setgid= is set in configure. If --with-setgid= is set, then --localstatedir= will allow the location of the common save and score files to be overridden (from /usr/local/var/games/angband to ${localstatedir}/angband).

It will also make USE_PRIVATE_PATHS orthogonal to --with-no-install, so that the private path is always used if setgid isn't.

Is there a requirement to override the private path location?

[magnate]

I'm not convinced that --with-no-install should use private paths. I agonise over this, it's a real Schrodinger of an issue.

[fizzix]

Punting, still unclear what the solution is.

[magnate]

Un-punting and assigning to noz as part of the wider buildsys changes, because this is actually quite a nasty bug: it means that shared score files simply don't happen, even when configuring --with-setgid for a system-wide install. See ​http://angband.oook.cz/forum/showthread.php?t=5490

[magnate]

Moved to 3.5.0 with a genuine intention to fix them by then.