Opened 9 years ago
Last modified 7 years ago
#1280 assigned bug
Allow --with-varpath to override PRIVATE_USER_DIR
Reported by: | magnate | Owned by: | noz |
---|---|---|---|
Milestone: | Future | Keywords: | cleanup build |
Cc: |
Description
On POSIX systems, configure ignores "varpath", even if it is set explicitly. Elly would like to be able to override this behaviour and set a varpath that isn't ~/.angband/Angband.
Change History (8)
comment:1 Changed 9 years ago by magnate
- Milestone changed from 3.3.0 to Future
- Status changed from new to confirmed
comment:2 Changed 8 years ago by magnate
- Milestone changed from Future to 3.4.0
- Owner set to magnate
- Status changed from confirmed to assigned
It's not configure that ignores varpath, it's in the code itself. Lines 120 and 211 in src/z-file.c both check for SET_UID (or) USE_PRIVATE_PATHS, when this should be && (and) I think.
comment:3 Changed 8 years ago by magnate
- Keywords cleanup,build added; cleanup removed
- Owner changed from magnate to noz
comment:4 Changed 8 years ago by noz
I'm intending to make USE_PRIVATE_PATHS get set by default, unless --with-setgid= is set in configure. If --with-setgid= is set, then --localstatedir= will allow the location of the common save and score files to be overridden (from /usr/local/var/games/angband to ${localstatedir}/angband).
It will also make USE_PRIVATE_PATHS orthogonal to --with-no-install, so that the private path is always used if setgid isn't.
Is there a requirement to override the private path location?
comment:5 Changed 8 years ago by magnate
- Keywords cleanup build added; cleanup,build removed
I'm not convinced that --with-no-install should use private paths. I agonise over this, it's a real Schrodinger of an issue.
comment:6 Changed 8 years ago by fizzix
- Milestone changed from 3.4.0 to 3.5.0
Punting, still unclear what the solution is.
comment:7 Changed 8 years ago by magnate
- Milestone changed from 3.5.0 to 3.4.0
- Type changed from task to bug
Un-punting and assigning to noz as part of the wider buildsys changes, because this is actually quite a nasty bug: it means that shared score files simply don't happen, even when configuring --with-setgid for a system-wide install. See http://angband.oook.cz/forum/showthread.php?t=5490
comment:8 Changed 7 years ago by magnate
- Milestone changed from 3.4.0 to 3.5.0
Moved to 3.5.0 with a genuine intention to fix them by then.
Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).